linux-kernel - Re: [PATCH v2 11/14] i2c/of: Factor out Devicetree registration code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141125141114.GB1843@katana>
Date:	Tue, 25 Nov 2014 15:11:14 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Grant Likely <grant.likely@...aro.org>
Cc:	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
	Rob Herring <robh+dt@...nel.org>,
	Mark Brown <broonie@...nel.org>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2 11/14] i2c/of: Factor out Devicetree registration code

On Mon, Nov 24, 2014 at 10:33:39PM +0000, Grant Likely wrote:
> From: Pantelis Antoniou <pantelis.antoniou@...sulko.com>
> 
> Dynamically inserting i2c client device nodes requires the use
> of a single device registration method. Factor out the loop body of
> of_i2c_register_devices() so that it can be called for individual
> device_nodes instead of for all the children of a node.
> 
> Note: The diff of this commit looks far more complicated than it
> actually is due the indentation being changed for a large block of code.
> When viewed using the diff -w flag to ignore whitespace changes it can
> be seen that the change is actually quite simple.
> 
> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@...sulko.com>
> [grant.likely: Made new function static and removed changes to header]
> Signed-off-by: Grant Likely <grant.likely@...aro.org>
> Cc: Wolfram Sang <wsa@...-dreams.de>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: linux-i2c@...r.kernel.org

Reviewed-by: Wolfram Sang <wsa@...-dreams.de>

I'd prefer that this series goes through your tree. There is still this
merge conflict, but that is an easy one like I mentioned in my last
review.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)