linux-kernel - Re: [PATCH V2 02/22] perf evlist: Add initial support for mmapping an Instruction Trace buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141125165752.GB563@krava.brq.redhat.com>
Date:	Tue, 25 Nov 2014 17:57:52 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH V2 02/22] perf evlist: Add initial support for mmapping
 an Instruction Trace buffer

On Thu, Nov 20, 2014 at 03:23:08PM +0200, Adrian Hunter wrote:

SNIP

> +			bool per_cpu __maybe_unused)
> +{
> +}
> +
>  static void __perf_evlist__munmap(struct perf_evlist *evlist, int idx)
>  {
>  	if (evlist->mmap[idx].base != NULL) {
> @@ -731,6 +759,7 @@ static void __perf_evlist__munmap(struct perf_evlist *evlist, int idx)
>  		evlist->mmap[idx].base = NULL;
>  		evlist->mmap[idx].refcnt = 0;
>  	}
> +	itrace_mmap__munmap(&evlist->mmap[idx].itrace_mmap);
>  }
>  
>  void perf_evlist__munmap(struct perf_evlist *evlist)
> @@ -758,6 +787,7 @@ static int perf_evlist__alloc_mmap(struct perf_evlist *evlist)
>  struct mmap_params {
>  	int prot;
>  	int mask;
> +	struct itrace_mmap_params itrace_mp;
>  };
>  
>  static int __perf_evlist__mmap(struct perf_evlist *evlist, int idx,
> @@ -788,6 +818,10 @@ static int __perf_evlist__mmap(struct perf_evlist *evlist, int idx,
>  		return -1;
>  	}
>  
> +	if (itrace_mmap__mmap(&evlist->mmap[idx].itrace_mmap,
> +			      &mp->itrace_mp, evlist->mmap[idx].base, fd))
> +		return -1;
> +

so the itrace mmap is mmaped with right after event mmap for event fd..?
is there any latest version of kernel changes, so I could check with
kernel's perf_mmap? hum.. or you just use the same mmap?

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/