linux-kernel - Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Nov 2014 01:37:51 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Dave Airlie <airlied@...il.com>, Joerg Roedel <jroedel@...e.de>
Cc:	Mark Yao <mark.yao@...k-chips.com>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Rob Clark <robdclark@...il.com>,
	Daniel Vetter <daniel@...ll.ch>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	Grant Likely <grant.likely@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	John Stultz <john.stultz@...aro.org>,
	Rom Lemarchand <romlem@...gle.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-doc@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-api@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	Douglas Anderson <dianders@...omium.org>,
	Stéphane Marchesin <marcheu@...omium.org>,
	dbehr@...omium.org, Olof Johansson <olof@...om.net>,
	Daniel Kurtz <djkurtz@...omium.org>,
	Eddie Cai <cf@...k-chips.com>, simon xue <xxm@...k-chips.com>,
	Tao Huang <huangtao@...k-chips.com>,
	Kever Yang <kever.yang@...k-chips.com>, yxj@...k-chips.com,
	xw@...k-chips.com
Subject: Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs

Hi Joerg, Dave,

Am Mittwoch, 26. November 2014, 09:12:56 schrieb Dave Airlie:
> On 26 November 2014 at 02:38, Heiko Stübner <heiko@...ech.de> wrote:
> > Mark,
> > 
> > Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao:
> >> This a series of patches is a DRM Driver for Rockchip Socs, add support
> >> for vop devices. Future patches will add additional encoders/connectors,
> >> such as eDP, HDMI.
> >> 
> >> The basic "crtc" for rockchip is a "VOP" - Video Output Processor.
> >> the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two similar
> >> Vop devices. Vop devices support iommu mapping, we use dma-mapping API
> >> with
> >> ARM_DMA_USE_IOMMU.
> > 
> > it looks like everybody is more or less happy with this version - in past
> > versions responses voicing concerns where quite swift.
> > 
> > As David requested a pull request the last time, it might be time to do
> > so, so that we maybe still reach 3.19.
> 
> I need the iommu changes the drm driver depends on in a stable
> maintainer git tree,
> I'm not pulling in code I can't build.

Joerg, is your arm/rockchip branch [0] considered stable?

[0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=arm/rockchip


> I'm happy if the rockchip drm pull stays static and I can pull it in
> once the iommu bits
> are done.

While testing this I noticed a quite big kconfig warning
(on both 3.18-rc1 and 3.18-rc6):

drivers/video/fbdev/Kconfig:5:error: recursive dependency detected!
drivers/video/fbdev/Kconfig:5:  symbol FB is selected by DRM_KMS_FB_HELPER
drivers/gpu/drm/Kconfig:34:     symbol DRM_KMS_FB_HELPER is selected by DRM_ROCKCHIP
drivers/gpu/drm/rockchip/Kconfig:1:     symbol DRM_ROCKCHIP depends on ARM_DMA_USE_IOMMU
arch/arm/Kconfig:95:    symbol ARM_DMA_USE_IOMMU is selected by VIDEO_OMAP3
drivers/media/platform/Kconfig:96:      symbol VIDEO_OMAP3 depends on VIDEO_V4L2
drivers/media/v4l2-core/Kconfig:6:      symbol VIDEO_V4L2 depends on I2C
drivers/i2c/Kconfig:7:  symbol I2C is selected by FB_DDC
drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER2000_DDC
drivers/video/fbdev/Kconfig:374:        symbol FB_CYBER2000_DDC depends on FB_CYBER2000
drivers/video/fbdev/Kconfig:362:        symbol FB_CYBER2000 depends on FB

It looks like the VIDEO_OMAP3 is selecting ARM_DMA_USE_IOMMU and
OMAP_IOMMU instead of depending on it.

I'm not sure which driver should change but looking at the exynos drm
driver it is also depends on the iommu parts instead of selecting them
[like the rockchip drm currently does]


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/