| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Nov 2014 10:13:50 +0100 From: Bartosz Golaszewski <bgolaszewski@...libre.com> To: Guenter Roeck <linux@...ck-us.net> Cc: LKML <linux-kernel@...r.kernel.org>, Benoit Cousson <bcousson@...libre.com>, Patrick Titiano <ptitiano@...libre.com> Subject: Re: [PATCH 1/5] hwmon: ina2xx: bail-out from ina2xx_probe() in case of configuration errors 2014-11-26 4:05 GMT+01:00 Guenter Roeck <linux@...ck-us.net>: > On 11/25/2014 10:30 AM, Guenter Roeck wrote: >> Repeating my earlier question: Is the resistor value changed by software >> or by changing the probe ? >> > > Looking into the available documents, I am quite sure that the resistor > is changed by replacing the probe, in other words by pulling the board > with the ina226 and replacing it with another one. Given that, configuring > the shunt resistor value with a sysfs attribute is really the wrong way > to do it; you should use probe specific devicetree overlays instead. Yes, it's changed by replacing the probes. As for the averaging rate: it's a programmable feature of the chip and it's useful for our user interface for noise reduction (or the opposite - to be able to see the actual distortion), can this be accepted after applying the fixes according to your review? Bart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists