linux-kernel - Re: [PATCH v4 11/42] virtio: add legacy feature table support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141126101957.6bd6989c.cornelia.huck@de.ibm.com>
Date:	Wed, 26 Nov 2014 10:19:57 +0100
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	rusty@....ibm.com, nab@...ux-iscsi.org, pbonzini@...hat.com,
	Rusty Russell <rusty@...tcorp.com.au>,
	Pawel Moll <pawel.moll@....com>,
	Ohad Ben-Cohen <ohad@...ery.com>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v4 11/42] virtio: add legacy feature table support

On Tue, 25 Nov 2014 23:39:42 +0200
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> On Tue, Nov 25, 2014 at 06:53:42PM +0100, Cornelia Huck wrote:
> > On Tue, 25 Nov 2014 18:42:09 +0200
> > "Michael S. Tsirkin" <mst@...hat.com> wrote:

> > > -	dev->features = driver_features & device_features;
> > > +	/* Some drivers have a separate feature tables for virtio v1.0 */
> > 
> > /* some drivers have a separate feature table for legacy virtio */
> > 
> > ?
> 
> I prefer have separate feature tables:  drivers (plural) have tables
> (plural).
> 
> Agree?

Yes, provided you drop the 'a' :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/