linux-kernel - Re: [PATCH v3 2/2] arm64: Add Juno board device tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5475ABC0.3090007@arm.com>
Date:	Wed, 26 Nov 2014 10:30:24 +0000
From:	Marc Zyngier <marc.zyngier@....com>
To:	Liviu Dudau <Liviu.Dudau@....com>,
	"arm@...nel.org" <arm@...nel.org>, Olof Johansson <olof@...om.net>,
	Arnd Bergmann <arnd@...db.de>,
	Kevin Hilman <khilman@...aro.org>
CC:	Mark Rutland <Mark.Rutland@....com>,
	device tree <devicetree@...r.kernel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Catalin Marinas <Catalin.Marinas@....com>,
	Will Deacon <Will.Deacon@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	LAKML <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/2] arm64: Add Juno board device tree.

Hi Liviu,

On 11/11/14 17:32, Liviu Dudau wrote:
> This adds support for ARM's Juno development board (rev 0).
> It enables most of the board peripherals: UART, I2C, USB, MMC and
> 100Mb ethernet. There is no support at the moment for clock setting
> and HDLCD driver which depends on it.
> 
> Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>
> ---
>  arch/arm64/boot/dts/arm/Makefile              |   1 +
>  arch/arm64/boot/dts/arm/juno-clocks.dtsi      |  45 ++++++
>  arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 129 +++++++++++++++
>  arch/arm64/boot/dts/arm/juno.dts              | 218 ++++++++++++++++++++++++++
>  4 files changed, 393 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/arm/juno-clocks.dtsi
>  create mode 100644 arch/arm64/boot/dts/arm/juno-motherboard.dtsi
>  create mode 100644 arch/arm64/boot/dts/arm/juno.dts
> 

[...]

> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts
> new file mode 100644
> index 0000000..097ecc4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/arm/juno.dts

[...]

> +       timer {
> +               compatible = "arm,armv8-timer";
> +               interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>,
> +                            <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>,
> +                            <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>,
> +                            <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_EDGE_RISING)>;
> +       };

Sorry, I should have spotted this earlier: all these interrupts are
*level*, not edge. This happens to work because the GIC's config
register is RO for PPIs on Juno, but still...

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/