linux-kernel - Re: [PATCH] fat: Fix oops on corrupted vfat fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r3wpw2jq.fsf@devron.myhome.or.jp>
Date:	Thu, 27 Nov 2014 16:00:41 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fat: Fix oops on corrupted vfat fs

Andrew Morton <akpm@...ux-foundation.org> writes:

> On Thu, 27 Nov 2014 00:31:28 +0900 OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> wrote:
>
>> a) don't bother with ->d_time for positives - we only check it for negatives
>> anyway.
>> b) make sure to set it at unlink and rmdir time - at *that* point soon-to-be
>> negative dentry matches then-current directory contents
>> c) don't go into renaming of old alias in vfat_lookup() unless it has
>> the same parent (which it will, unless we are seeing corrupted image)
>> 
>> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
>> Cc: <stable@...r.kernel.org> # 3.17.x
>> [Make change minimum, don't call d_move() for dir]
>> Signed-off-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
>
> It's unclear who did the "[Make change minimum.." alteration.
>
> I do it this way:
> [hirofumi@...l.parknet.co.jp: make change minimum, don't call d_move() for dir]

I see. OK, I will also use your format next time.

> Also, who was the primary author of this patch?  It *looks* like it was
> Al, unsure.  If it was indeed Al then this can be communicated by
> putting his From: line at the very top of the changelog body.

Ah, sorry. The patch is written by Al, and I was forgetting to add "From:".
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/