linux-kernel - Re: [PATCH v2 4/9] staging: panel: Use defined value or checking module params state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141127152417.GB23247@kroah.com>
Date:	Thu, 27 Nov 2014 07:24:17 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Mariusz Gorski <marius.gorski@...il.com>
Cc:	devel@...verdev.osuosl.org, Willy Tarreau <w@....eu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/9] staging: panel: Use defined value or checking
 module params state

On Thu, Nov 27, 2014 at 02:26:59PM +0100, Mariusz Gorski wrote:
> On Wed, Nov 26, 2014 at 01:58:01PM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote:
> > > Avoid magic number and use a comparison with a defined value instead
> > > that checks whether module param has been set by the user to some
> > > value at loading time.
> > > 
> > > Signed-off-by: Mariusz Gorski <marius.gorski@...il.com>
> > > Acked-by: Willy Tarreau <w@....eu>
> > > ---
> > > v2: Don't introduce new macros for param value check
> > > 
> > >  drivers/staging/panel/panel.c | 86 +++++++++++++++++++++----------------------
> > >  1 file changed, 43 insertions(+), 43 deletions(-)
> > 
> > Ugh, I messed up here, and applied the first series, which was acked.
> > 
> > Mariusz, can you resend the patches that I didn't apply, I can't seem to
> > get the rest of these to work properly.
> 
> Greg, if I get you here correctly, you've applied all 9 patches from v1
> and none from v2, so what you need now is a v1->v2 patch, right?

No, I think I applied the patches sent _before_ the 9 series, it was 4
or 5 or so, you should have gotten an email about them.  Pull my
staging-testing branch and redo your remaining patches please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/