linux-kernel - Re: [PATCH 2/2] m32r: Add missing big-endian I/O accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75201216.LyHlPqmjDS@wuerfel>
Date:	Thu, 27 Nov 2014 18:52:58 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Kevin Cernekee <cernekee@...il.com>
Cc:	grant.likely@...aro.org, kbuild-all@...org,
	gregkh@...uxfoundation.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] m32r: Add missing big-endian I/O accessors

On Thursday 27 November 2014 09:46:44 Kevin Cernekee wrote:
>  #define iowrite32 writel
>  
> +#define ioread16be(addr)       be16_to_cpu(readw(addr))
> +#define ioread32be(addr)       be32_to_cpu(readl(addr))
> +#define iowrite16be(val, addr) writew(cpu_to_be16(val), addr)
> +#define iowrite32be(val, addr) writel(cpu_to_be32(val), addr)
> +
> 

m32r can be either little-endian or big-endian, so these need to
unconditionally swap instead.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/