linux-kernel - Re: [RFC PATCH 2/4] rtc: Convert rtc_class_ops.set_mmss() to use time64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1411280003020.3961@nanos>
Date:	Fri, 28 Nov 2014 00:05:34 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Xunlei Pang <pang.xunlei@...aro.org>
cc:	linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Sven Schnelle <svens@...ckframe.org>,
	John Stultz <john.stultz@...aro.org>,
	Arnd Bergmann <arnd.bergmann@...aro.org>
Subject: Re: [RFC PATCH 2/4] rtc: Convert rtc_class_ops.set_mmss() to use
 time64_t

On Thu, 27 Nov 2014, Xunlei Pang wrote:
> -static int coh901331_set_mmss(struct device *dev, unsigned long secs)
> +static int coh901331_set_mmss(struct device *dev, time64_t secs)
>  {
>  	struct coh901331_port *rtap = dev_get_drvdata(dev);
>  
>  	clk_enable(rtap->clk);
> +	/*
> +	 * y2106 issue:
> +	 *   On 32bit systems the time64_t secs value gets cast to
> +	 *   a 32bit long, and thus we can only write a maximum value
> +	 *   of y2016

That really makes a lot of sense. Before that patch the driver was
safe up to 2038. Now it is facing the y2016 problem.

> +	/*
> +	 * y2106 issue:
> +	 *   On 32bit systems the time64_t secs value gets cast to
> +	 *   a 32bit long, and thus we can only write a maximum value
> +	 *   of y2016

Copy and paste is wonderful, right?

Sigh,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/