[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141128111327.GR3836@n2100.arm.linux.org.uk>
Date: Fri, 28 Nov 2014 11:13:27 +0000
From: Russell King - ARM Linux <linux@....linux.org.uk>
To: "Jon Medhurst (Tixy)" <tixy@...aro.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
Wang Nan <wangnan0@...wei.com>, will.deacon@....com,
taras.kondratiuk@...aro.org, ben.dooks@...ethink.co.uk,
cl@...ux.com, rabin@....in, davem@...emloft.net,
lizefan@...wei.com, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: Re: [PATCH v10 2/2] ARM: kprobes: enable OPTPROBES for ARM 32
On Fri, Nov 28, 2014 at 10:08:28AM +0000, Jon Medhurst (Tixy) wrote:
> On Fri, 2014-11-28 at 12:12 +0900, Masami Hiramatsu wrote:
> > (2014/11/27 23:36), Jon Medhurst (Tixy) wrote:
> [...]
> > > I thought it good to see what sort of benefits this code achieves,
> > > especially as it could grow quite complex over time, and the cost of
> > > that versus the benefit should be considered.
> >
> > I don't think it's so complex. It's actually cleanly separated.
> > However, ARM tree should have arch/arm/kernel/kprobe/ dir,
> > since there are too many kprobe related files under arch/arm/kernel/ ...
>
> Yes, that does seem like a good idea. Or rather a 'probes' directory to
> also include uprobes as that shares a lot of code with kprobes.
If you want to do this, then please make it arch/arm/probes rather than
making the directory tree deeper than it needs to be.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists