| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141128113111.GO4508@piout.net> Date: Fri, 28 Nov 2014 12:31:12 +0100 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Arnd Bergmann <arnd@...db.de> Cc: Alexander Stein <alexanders83@....de>, linux-arm-kernel@...ts.infradead.org, Boris BREZILLON <boris.brezillon@...e-electrons.com>, Nicolas Ferre <nicolas.ferre@...el.com>, linux-kernel@...r.kernel.org, Ludovic Desroches <ludovic.desroches@...el.com>, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> Subject: Re: [PATCH 00/11] ARM: at91: remove !DT support for at91rm9200 On 28/11/2014 at 09:49:10 +0100, Arnd Bergmann wrote : > > > Actually, some work was done but we never saw an other version of the > > > series. Alexander, are you still interested? Else we can take the patch > > > below. > > > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-April/246679.html > > I see. Yes, the approach is similar, and there are actually multiple > independent problems: > > - getting the current driver to build with multiplatform (trivial, 5 lines) > - changing the gpio handling to work with DT (simple, both of us did that) > - writing the binding (simple) Yeah, let's focus on those first steps. Takashi was willing to take patches, even if we were not converting the driver to ASoC. > - changing the driver to ASoC (not that simple) > > > Well, I tried to get a ac97c driver based on alsa soc framework as suggested > > by Takashi. But I failed so far, I could not get my head around those > > architecture. > > Let's just start with the trivial first patch, that can probably just be merged > into 3.19, and then we can build on top of that later if anybody wants to > get ac97 working again on at91. > Do you want one of us to send that patch to Takashi and the Alsa ML or will you do it? You can add my ack. > > When keeping my DT support on the current driver, the only thing which is open > > that the bindings should be modifed that they are like soc-ac97link bindings. > > Makes sense, if that binding works on the at91 hardware. I'm not sure > whether the pinctrl stuff or the first two gpio lines apply though. > > Arnd > > 8<--- > ALSA: atmel: fix building the ac97 driver for at91-multiplatform > > at91 will no longer export the mach/cpu.h and mach/hardware.h header files > in the future, which would break building the atmel ac97c driver. > > Since the cpu_is_* check is only used to find out whether we are running > on avr32 or arm/at91, we can hardcode that check in the ARM case. > > Unfortunately the driver is missing other work to be useful again on ARM, > if anyone wants to actually use it, they need to add a DT binding, and > the driver should really be converted to use the ASoC framework. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Link: http://www.spinics.net/lists/arm-kernel/msg382068.html > > diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c > index b59427d5a697..4eec216b7f92 100644 > --- a/sound/atmel/ac97c.c > +++ b/sound/atmel/ac97c.c > @@ -34,10 +34,10 @@ > #include <linux/platform_data/dma-dw.h> > #include <linux/dma/dw.h> > > +#ifdef CONFIG_AVR32 > #include <mach/cpu.h> > - > -#ifdef CONFIG_ARCH_AT91 > -#include <mach/hardware.h> > +#else > +#define cpu_is_at32ap7000() (0) > #endif > > #include "ac97c.h" > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists