linux-kernel - Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141128133034.GA4635@ks395439.kimsufi.com>
Date:	Fri, 28 Nov 2014 14:30:34 +0100
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, eunb.song@...sung.com,
	aaro.koskinen@....fi, paul.gortmaker@...driver.com
Subject: Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote:
> On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote:
> > Fixing 80 character limit warnings in octeon/ethernet-rx.c
> > 
> > Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> > ---
> >  drivers/staging/octeon/ethernet-rx.c | 51 +++++++++++++++++++++++++-----------
> >  1 file changed, 35 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> > index 1789a12..e387eb1 100644
> > --- a/drivers/staging/octeon/ethernet-rx.c
> > +++ b/drivers/staging/octeon/ethernet-rx.c
> > @@ -109,6 +109,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work)
> >  		int interface = cvmx_helper_get_interface_num(work->ipprt);
> >  		int index = cvmx_helper_get_interface_index_num(work->ipprt);
> >  		union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl;
> > +
> 
> Do this in a separate patch.

Will do within the hour.

> 
> > @@ -332,8 +343,10 @@ static int cvm_oct_napi_poll(struct napi_struct *napi, int budget)
> >  				skb->protocol = eth_type_trans(skb, dev);
> >  				skb->dev = dev;
> >  
> > -				if (unlikely(work->word2.s.not_IP || work->word2.s.IP_exc ||
> > -					work->word2.s.L4_error || !work->word2.s.tcp_or_udp))
> > +				if (unlikely(work->word2.s.not_IP ||
> > +					work->word2.s.IP_exc ||
> > +					work->word2.s.L4_error ||
> > +					!work->word2.s.tcp_or_udp))
> >  					skb->ip_summed = CHECKSUM_NONE;
> 
> Your patch aligns everything with tabs but it should be slightly
> different.  Run your patch through checkpatch.pl --strict to see what I
> mean and then redo it all.  This one should look like:
> 
> 				if (unlikely(work->word2.s.not_IP ||
> 					     work->word2.s.IP_exc ||
> 					     work->word2.s.L4_error ||
> 					     !work->word2.s.tcp_or_udp))
> 					skb->ip_summed = CHECKSUM_NONE;
> 
> [tab][tab][tab][tab][tab][space][space][space][space][space]work->...
> 
> regards,
> dan carpenter
> 
> 

Fixed the aligns and resubmitting the patch as v3.

Thanks for the review!
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/