linux-kernel - Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141128142621.GA8571@ks395439.kimsufi.com>
Date:	Fri, 28 Nov 2014 15:26:21 +0100
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, aaro.koskinen@....fi,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	paul.gortmaker@...driver.com, eunb.song@...sung.com
Subject: Re: [PATCH v2] staging: octeon: Fix checkpatch warnings

On Fri, Nov 28, 2014 at 05:14:32PM +0300, Dan Carpenter wrote:
> On Fri, Nov 28, 2014 at 02:30:34PM +0100, Luis de Bethencourt wrote:
> > On Fri, Nov 28, 2014 at 01:29:28PM +0300, Dan Carpenter wrote:
> > > On Thu, Nov 27, 2014 at 05:18:10PM +0100, Luis de Bethencourt wrote:
> > > > Fixing 80 character limit warnings in octeon/ethernet-rx.c
> > > > 
> > > > Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> > > > ---
> > > >  drivers/staging/octeon/ethernet-rx.c | 51 +++++++++++++++++++++++++-----------
> > > >  1 file changed, 35 insertions(+), 16 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c
> > > > index 1789a12..e387eb1 100644
> > > > --- a/drivers/staging/octeon/ethernet-rx.c
> > > > +++ b/drivers/staging/octeon/ethernet-rx.c
> > > > @@ -109,6 +109,7 @@ static inline int cvm_oct_check_rcv_error(cvmx_wqe_t *work)
> > > >  		int interface = cvmx_helper_get_interface_num(work->ipprt);
> > > >  		int index = cvmx_helper_get_interface_index_num(work->ipprt);
> > > >  		union cvmx_gmxx_rxx_frm_ctl gmxx_rxx_frm_ctl;
> > > > +
> > > 
> > > Do this in a separate patch.
> > 
> > Will do within the hour.
> > 
> 
> :(  You should always wait overnight or a few hours before sending a
> patch.  It's not a race.  Go slowly.
> 
> regards,
> dan carpenter
> 

Is the wait so people have more time to review the patch as it is?
I wanted to show my interest by keeping up with reviews but now that you
mention that, it makes sense.

I screwed up and didn't submit the version 3 of this patch with [01/02] for the
character limit warnings. Will wait, since the patch for the empty lines after
variable declarations needs to be applied on-top of this. I will wait until that
one is accepted or rejected before rebasing and submitting the second patch.

Sorry about this.

Thanks for all the help :)

Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/