linux-kernel - Re: [PATCH 06/17] net2280: Remove restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54788AC3.9090808@cogentembedded.com>
Date:	Fri, 28 Nov 2014 17:46:27 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter Chen <peter.chen@...escale.com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/17] net2280: Remove restart_dma inline function definition

Hello.

On 11/28/2014 04:50 PM, Ricardo Ribalda Delgado wrote:

> restart_dma is not used before it is declaration. Therefore we can

    s/it is/its/.

> remove this definition.

    You're removing the declaration, not definition.

> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>   drivers/usb/gadget/udc/net2280.c | 2 --
>   1 file changed, 2 deletions(-)

> diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> index 0340462..e8c36db 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -1043,8 +1043,6 @@ dma_done(struct net2280_ep *ep,	struct net2280_request *req, u32 dmacount,
>   	done(ep, req, status);
>   }
>
> -static void restart_dma(struct net2280_ep *ep);
> -
>   static void scan_dma_completions(struct net2280_ep *ep)
>   {
>   	/* only look at descriptors that were "naturally" retired,

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/