linux-kernel - Re: [PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC in dts and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141128145035.GO7712@sirena.org.uk>
Date:	Fri, 28 Nov 2014 14:50:35 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Will Deacon <will.deacon@....com>
Cc:	Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"heiko@...ech.de" <heiko@...ech.de>,
	"gnomes@...rguk.ukuu.org.uk" <gnomes@...rguk.ukuu.org.uk>,
	Chunyan Zhang <chunyan.zhang@...eadtrum.com>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"jason@...edaemon.net" <jason@...edaemon.net>,
	"lanqing.liu@...eadtrum.com" <lanqing.liu@...eadtrum.com>,
	Pawel Moll <Pawel.Moll@....com>,
	"corbet@....net" <corbet@....net>,
	"zhang.lyra@...il.com" <zhang.lyra@...il.com>,
	"zhizhou.zhang@...eadtrum.com" <zhizhou.zhang@...eadtrum.com>,
	"geng.ren@...eadtrum.com" <geng.ren@...eadtrum.com>,
	"m-karicheri2@...com" <m-karicheri2@...com>,
	"shawn.guo@...escale.com" <shawn.guo@...escale.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"orsonzhai@...il.com" <orsonzhai@...il.com>,
	"florian.vaussard@...l.ch" <florian.vaussard@...l.ch>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"artagnon@...il.com" <artagnon@...il.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Marc Zyngier <Marc.Zyngier@....com>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"hytszk@...il.com" <hytszk@...il.com>,
	"rrichter@...ium.com" <rrichter@...ium.com>,
	"wei.qiao@...eadtrum.com" <wei.qiao@...eadtrum.com>,
	"sprdlinux@...elists.org" <sprdlinux@...elists.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC
 in dts and Makefile

On Fri, Nov 28, 2014 at 02:44:12PM +0000, Will Deacon wrote:
> On Fri, Nov 28, 2014 at 02:35:32PM +0000, Mark Rutland wrote:

> > Probably too rude, given it doesn't WARN() the user.

> We override broken hardware ID registers all the time in device-tree without
> dumping stack. Why is this any different?

I do tend to agree that a WARN() is excessive but given the amount of
pushback on using this property on ARMv8 systems saying something would
be nice, though...

> > We should be extremely loud if we see the clock-frequency property on an
> > arm64 system. Whether or not we should ignore the property is another
> > matter.

> I don't really see the point in ignoring it. We will see broken hardware
> [1] and this is just preventing ourselves from working around it. I'd much
> rather have arch-timers with a "clock-frequence" property than have some
> other timer instead because the kernel driver is being stubborn.

...it is likely that even if there is a warning we'll end up in this
situation.  If the kernel doesn't complain at all it seems totally
reasonable for people to use the feature, but just refusing to allow it
to be used at all doesn't seem like it's actually helping things.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)