linux-kernel - Re: [PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC in dts and Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141128172431.GA32393@e104818-lin.cambridge.arm.com>
Date:	Fri, 28 Nov 2014 17:24:31 +0000
From:	Catalin Marinas <catalin.marinas@....com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	"andrew@...n.ch" <andrew@...n.ch>,
	"heiko@...ech.de" <heiko@...ech.de>,
	"gnomes@...rguk.ukuu.org.uk" <gnomes@...rguk.ukuu.org.uk>,
	Will Deacon <Will.Deacon@....com>,
	Chunyan Zhang <chunyan.zhang@...eadtrum.com>,
	"jason@...edaemon.net" <jason@...edaemon.net>,
	"lanqing.liu@...eadtrum.com" <lanqing.liu@...eadtrum.com>,
	"arnd@...db.de" <arnd@...db.de>, "corbet@....net" <corbet@....net>,
	"zhang.lyra@...il.com" <zhang.lyra@...il.com>,
	"zhizhou.zhang@...eadtrum.com" <zhizhou.zhang@...eadtrum.com>,
	"geng.ren@...eadtrum.com" <geng.ren@...eadtrum.com>,
	"m-karicheri2@...com" <m-karicheri2@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	"orsonzhai@...il.com" <orsonzhai@...il.com>,
	"florian.vaussard@...l.ch" <florian.vaussard@...l.ch>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"artagnon@...il.com" <artagnon@...il.com>,
	Pawel Moll <Pawel.Moll@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Marc Zyngier <Marc.Zyngier@....com>,
	"hytszk@...il.com" <hytszk@...il.com>,
	"rrichter@...ium.com" <rrichter@...ium.com>,
	"broonie@...nel.org" <broonie@...nel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"wei.qiao@...eadtrum.com" <wei.qiao@...eadtrum.com>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"sprdlinux@...elists.org" <sprdlinux@...elists.org>,
	"shawn.guo@...escale.com" <shawn.guo@...escale.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"broonie@...aro.org" <broonie@...aro.org>
Subject: Re: [PATCH v3 3/5] arm64: dts: Add support for Spreadtrum SC9836 SoC
 in dts and Makefile

On Fri, Nov 28, 2014 at 04:40:47PM +0000, Mark Rutland wrote:
> [...]
> 
> > In the meantime I think we can be more tolerant:
> > 
> > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> > index 2133f9d59d06..87f67a93fcc7 100644
> > --- a/drivers/clocksource/arm_arch_timer.c
> > +++ b/drivers/clocksource/arm_arch_timer.c
> > @@ -376,6 +376,8 @@ arch_timer_detect_rate(void __iomem *cntbase, struct device_node *np)
> >  			arch_timer_rate = readl_relaxed(cntbase + CNTFRQ);
> >  		else
> >  			arch_timer_rate = arch_timer_get_cntfrq();
> > +	} else if (IS_ENABLED(CONFIG_ARM64)) {
> > +		pr_warn("Architected timer frequency overridden by DT (broken firmware?)\n");
> >  	}
> 
> That looks good to me. On a related note, it looks like my documentation
> patch [1] from a while back fell by the wayside. Does anyone fancy
> picking that up to go with this?

I can put the two together (keeping you as author). Do we still need the
IS_ENABLED(CONFIG_ARM64) part here or we extend the warning to to arm32
as well?

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/