lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Nov 2014 19:23:31 +0200 From: "Michael S. Tsirkin" <mst@...hat.com> To: Jason Wang <jasowang@...hat.com> Cc: linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>, cornelia.huck@...ibm.com, rusty@....ibm.com, nab@...ux-iscsi.org, pbonzini@...hat.com, thuth@...ux.vnet.ibm.com, dahi@...ux.vnet.ibm.com, Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>, Tom Herbert <therbert@...gle.com>, Ben Hutchings <ben@...adent.org.uk>, Masatake YAMATO <yamato@...hat.com>, Herbert Xu <herbert@...dor.apana.org.au>, Xi Wang <xii@...gle.com>, netdev@...r.kernel.org Subject: Re: [PATCH v6 38/46] tun: drop most type defines On Fri, Nov 28, 2014 at 08:17:48AM +0008, Jason Wang wrote: > > > On Fri, Nov 28, 2014 at 4:11 AM, Michael S. Tsirkin <mst@...hat.com> wrote: > >It's just as easy to use IFF_ flags directly, > >there's no point in adding our own defines. > > > >Signed-off-by: Michael S. Tsirkin <mst@...hat.com> > >--- > > drivers/net/tun.c | 62 > >+++++++++++++++++++++++++------------------------------ > > 1 file changed, 28 insertions(+), 34 deletions(-) > > > >diff --git a/drivers/net/tun.c b/drivers/net/tun.c > > Patch looks fine, but I don't see the reason that why not squash patch 37 > into this. > > [..] squashing is always easy, I thought review is easier if at each step identity to original code can be verified directly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists