lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Nov 2014 19:32:26 +0200 From: "Michael S. Tsirkin" <mst@...hat.com> To: David Hildenbrand <dahi@...ux.vnet.ibm.com> Cc: linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>, cornelia.huck@...ibm.com, rusty@....ibm.com, nab@...ux-iscsi.org, pbonzini@...hat.com, thuth@...ux.vnet.ibm.com, Rusty Russell <rusty@...tcorp.com.au>, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH v6 01/46] virtio: add low-level APIs for feature bits On Fri, Nov 28, 2014 at 01:10:57PM +0100, David Hildenbrand wrote: > > Add low level APIs to test/set/clear feature bits. > > For use by transports, to make it easier to > > write code independent of feature bit array format. > > > > Signed-off-by: Michael S. Tsirkin <mst@...hat.com> > > --- > > include/linux/virtio_config.h | 53 ++++++++++++++++++++++++++++++++++++++++--- > > 1 file changed, 50 insertions(+), 3 deletions(-) > > > > As these functions really set feature bits, I would rather name them: > > virtio_has_feature ... > virtio_set_feature ... > virtio_clear_feature ... We have these as high level APIs for drivers. These are low level ones so need a different name. > But in general, this looks good to me! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists