linux-kernel - Re: [PATCH] Fixed type id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFLxGvzH3yKWBATBYmxQteXgVZvY0mwEE7+Oi7Tx+ZkyV66LQA@mail.gmail.com>
Date:	Sat, 29 Nov 2014 11:26:08 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Ren Kimura <rkx1209@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fixed type id

On Sat, Nov 29, 2014 at 11:13 AM, Ren Kimura <rkx1209@...il.com> wrote:
> From: RKX1209 <rkx1209@...il.com>
>
> Signed-off-by: RKX1209 <rkx1209@...il.com>

What issue does this fix?
On 32bit an address should fit into an integer.

> ---
>  arch/x86/mm/init_32.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c
> index c8140e1..957f7f0 100644
> --- a/arch/x86/mm/init_32.c
> +++ b/arch/x86/mm/init_32.c
> @@ -304,14 +304,14 @@ repeat:
>  #endif
>                 for (; pmd_idx < PTRS_PER_PMD && pfn < end_pfn;
>                      pmd++, pmd_idx++) {
> -                       unsigned int addr = pfn * PAGE_SIZE + PAGE_OFFSET;
> +                       unsigned long addr = pfn * PAGE_SIZE + PAGE_OFFSET;
>
>                         /*
>                          * Map with big pages if possible, otherwise
>                          * create normal page tables:
>                          */
>                         if (use_pse) {
> -                               unsigned int addr2;
> +                               unsigned long addr2;
>                                 pgprot_t prot = PAGE_KERNEL_LARGE;
>                                 /*
>                                  * first pass will use the same initial
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/