lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Nov 2014 14:45:48 +0100 From: Belisko Marek <marek.belisko@...il.com> To: Geoff Darst <geoffda@...cast.net> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Staging: ft1000 : ft1000-pcmcia: replace __attribute ((__packed__) with __packed macro per coding style guidelines in ft1000_dnld.c Please use shorter summary phrase (which appear an subject) + split commit message to more line (not one long line). marek On Sat, Nov 29, 2014 at 3:49 AM, Geoff Darst <geoffda@...cast.net> wrote: > Replace two instances of __attribute ((__packed__) with __packed macro to address the warning found by the checkpatch.pl tool. > > Signed-off-by: Geoff Darst <geoffda@...cast.net> > --- > drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c > index c1856f7..df1cf0c 100644 > --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c > +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c > @@ -99,7 +99,7 @@ struct dsp_file_hdr { > u32 version_data_offset; /* Offset were scrambled version data begins. */ > u32 version_data_size; /* Size, in words, of scrambled version data. */ > u32 nDspImages; /* Number of DSP images in file. */ > -} __attribute__ ((packed)); > +} __packed; > > struct dsp_image_info { > u32 coff_date; /* Date/time when DSP Coff image was built. */ > @@ -110,7 +110,7 @@ struct dsp_image_info { > u32 version; /* Embedded version # of DSP code. */ > unsigned short checksum; /* Dsp File checksum */ > unsigned short pad1; > -} __attribute__ ((packed)); > +} __packed; > > void card_bootload(struct net_device *dev) > { > -- > 1.9.3 > -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists