linux-kernel - Re: [PATCH] drivers:gpu:drm Remove unneeded struct of type psb_intel_i2c_chan in the header file psb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAMeQTsaOOMmw1ECZ+KZN8iyGB3ePFjAU_H55E2LRooexKOnijg@mail.gmail.com>
Date:	Sun, 30 Nov 2014 14:02:44 +0100
From:	Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, Dave Airlie <airlied@...hat.com>,
	Arthur Borsboom <arthurborsboom@...il.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers:gpu:drm Remove unneeded struct of type
 psb_intel_i2c_chan in the header file psb_drv.h

On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause <xerofoify@...il.com> wrote:
> Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this struct
> is no needed due to never being used in the header file, psb_drv.h and therefore
> should be removed from this header file.
>
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>

The lvds_i2c_bus is in use and can't be removed. Please at least compile test
your patches before submitting them.

Cheers
Patrik

> ---
>  drivers/gpu/drm/gma500/psb_drv.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
> index 55ebe2b..fc74518 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.h
> +++ b/drivers/gpu/drm/gma500/psb_drv.h
> @@ -522,7 +522,6 @@ struct drm_psb_private {
>         struct drm_display_mode *sdvo_lvds_vbt_mode;
>
>         struct bdb_lvds_backlight *lvds_bl; /* LVDS backlight info from VBT */
> -       struct psb_intel_i2c_chan *lvds_i2c_bus; /* FIXME: Remove this? */
>
>         /* Feature bits from the VBIOS */
>         unsigned int int_tv_support:1;
> --
> 2.1.0
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/