linux-kernel - Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 30 Nov 2014 20:54:40 +0100
From:	Loïc Pefferkorn <loic@...cp.eu>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	oleg.drokin@...el.com, andreas.dilger@...el.com, gdonald@...il.com,
	keith.mannthey@...el.com, john.hammond@...el.com,
	devel@...verdev.osuosl.org, HPDD-discuss@...ts.01.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: fix sparse warnings related to lock
 context imbalance

On Fri, Nov 28, 2014 at 02:22:07PM -0800, Greg KH wrote:
> 
> That's even worse than I imagined.  Putting sparse markings on these
> function calls is just papering over nonsense.  Please work on unwinding
> the mess so that you don't need callbacks for locks, that is an
> abstraction that isn't needed.
> 
> Same here, ick ick ick.
> 
> 
> Don't hide "implementation of locks" in functions like this, it only
> causes problems.  This code has layers of layers of layers of
> abstractions due to it wanting to be originally ported to other
> operating systems and lots of different kernel versions of Linux itself.
> Unwinding and removing those layers is a good thing to do, don't paper
> over the nonsense by putting sparse markings on pointless functions.
> 
> thanks,

Hi guys,

Thanks for your reply. I'm going to write a v2.

-- 
Cheers,
Loïc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/