linux-kernel - Re: [PATCH v7 44/46] virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8t6Gp8XyCAM8DVFrhyJzN5wdEMv8nn59mCP1FP6QQLwXg@mail.gmail.com>
Date:	Sun, 30 Nov 2014 21:43:23 +0000
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>, cornelia.huck@...ibm.com,
	rusty@....ibm.com, nab@...ux-iscsi.org, pbonzini@...hat.com,
	thuth@...ux.vnet.ibm.com, dahi@...ux.vnet.ibm.com,
	Rusty Russell <rusty@...tcorp.com.au>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Bjarke Istrup Pedersen <gurligebis@...too.org>,
	Andy Grover <agrover@...hat.com>,
	stephen hemminger <stephen@...workplumber.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Anup Patel <anup.patel@...aro.org>,
	linux-api <linux-api@...r.kernel.org>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v7 44/46] virtio_scsi: export to userspace

Hi Michael,

Thanks for the patch.

On Sun, Nov 30, 2014 at 3:12 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
> Replace uXX by __uXX and _packed by __attribute((packed))
> as seems to be the norm for userspace headers.
>
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> Acked-by: Paolo Bonzini <pbonzini@...hat.com>

> ---
>  include/uapi/linux/virtio_scsi.h | 74 ++++++++++++++++++++--------------------
>  include/uapi/linux/Kbuild        |  1 +

Probably worth making a separate patch for this ? as it doesnt
match with patch description aswel.

Apart from that patch looks good.

Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/