linux-kernel - Re: [PATCH] sound: use enum names instead of magic numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hwq6d9hze.wl-tiwai@suse.de>
Date:	Sun, 30 Nov 2014 10:04:53 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Joe Perches <joe@...ches.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: use enum names instead of magic numbers

At Sun, 30 Nov 2014 00:55:32 -0800,
Joe Perches wrote:
> 
> On Sun, 2014-11-30 at 09:41 +0100, Takashi Iwai wrote:
> > At Sat, 29 Nov 2014 12:58:12 -0800,
> > Joe Perches wrote:
> > > 
> > > There's an enum defined for these magic numbers,
> > > might as well use it.
> > > 
> > > Miscellanea:
> > > o Use ##__VA_ARGS__
> > > 
> > > Signed-off-by: Joe Perches <joe@...ches.com>
> > 
> > Any specific reason to hang to an irrelevant thread?
> 
> Not in particular, I just noticed it there.
> 
> > Also...
> 
> > > diff --git a/include/sound/core.h b/include/sound/core.h
> []
> > > +#define __snd_printk(snd_level, file, line, format, ...) \
> > > +	printk(format, ##__VA_ARGS__)
> > 
> > It's better to keep the argument name "level".  Using both the same
> > name for a variable and its enum type is rather confusing, and just
> > gives unnecessary LOCs.
> 
> Write it as you chose.  It is pretty trivial.

... trivial for anyone ;)


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/