linux-kernel - Re: [PATCH] kvm: arm: vgic: Let one looping code instead of two looping code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141130110842.GA83910@macair>
Date:	Sun, 30 Nov 2014 12:08:42 +0100
From:	Christoffer Dall <christoffer.dall@...aro.org>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Marc Zyngier <marc.zyngier@....com>,
	"gleb@...nel.org" <gleb@...nel.org>,
	Paolo Bonzini <pbonzini@...hat.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kvm: arm: vgic: Let one looping code instead of two
 looping code

On Mon, Dec 01, 2014 at 10:04:32PM +0800, Chen Gang wrote:
> On 11/30/2014 06:07 PM, Christoffer Dall wrote:
> > On Sun, Nov 30, 2014 at 12:18:04PM +0800, Chen Gang wrote:
> >> Use one looping instead of two, so can let code more simpler and get a
> >> little better performance.
> >>
> >> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> > 
> > Performance?  Please, this is vgic_create....
> > 
> 
> I guess your meaning is "this code is not performance sensitive", do not
> mean "1 looping can not get a little better performance than 2 looping".
> If what I guess is incorrect, please let me know.
> 

I doubt if this is even measureable.  Have you even looked at how this
compiles?

> > This does nothing else than introduce churn.
> > 
> 
> I don't think it does nothing, it can let code simpler than before:
> remove the redundant looping -- the 2 looping do the same thing which
> is commented just above the firstly looping.

I don't think there's any big benefit here.

> 
> And I don't know which churn this patch will introduce. At least, no one
> want to waste him/her time resources to intend churn, please provide
> more details about it.
> 
> If kvm does not like me, or does not like members to find issues based
> on reading source code, please let me know (no reply means kvm does not
> like me or this way), I will quit, so can save time resources both.
> 
I appreciate your efforts and welcome anybody to contribute to the code
base.  But you seem to be insisting on changing some insignificant
details, and we just have bigger fish to fry right now.  Sorry.

This is not about anyone not liking someone, it is about the code and
whether there's a need to take this patch right now or not.

-Christoffer
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/