linux-kernel - Re: [PATCH 4/4] usbip: remove unneeded structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABdoFFem4O8X1R1-DBftpxaPSo83hcmhF-WGUjUGY_fUJjGEUg@mail.gmail.com>
Date:	Mon, 1 Dec 2014 10:39:19 +0200
From:	Valentina Manea <valentina.manea.m@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Shuah Khan <shuah.kh@...sung.com>, linux-usb@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] usbip: remove unneeded structure

On Sun, Nov 30, 2014 at 8:14 PM, Julia Lawall <Julia.Lawall@...6.fr> wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
>
> Delete a local structure that is only used to be initialized by memset.
>
> A semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x,i;
> @@
>
> {
> ... when any
> -struct i x;
> <+... when != x
> - memset(&x,...);
> ...+>
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
>
> ---
>  tools/usb/usbip/src/usbipd.c |    2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/usb/usbip/src/usbipd.c b/tools/usb/usbip/src/usbipd.c
> index 2f87f2d..2a7cd2b 100644
> --- a/tools/usb/usbip/src/usbipd.c
> +++ b/tools/usb/usbip/src/usbipd.c
> @@ -91,7 +91,6 @@ static void usbipd_help(void)
>  static int recv_request_import(int sockfd)
>  {
>         struct op_import_request req;
> -       struct op_common reply;
>         struct usbip_exported_device *edev;
>         struct usbip_usb_device pdu_udev;
>         struct list_head *i;
> @@ -100,7 +99,6 @@ static int recv_request_import(int sockfd)
>         int rc;
>
>         memset(&req, 0, sizeof(req));
> -       memset(&reply, 0, sizeof(reply));
>
>         rc = usbip_net_recv(sockfd, &req, sizeof(req));
>         if (rc < 0) {
>

Acked-by: Valentina Manea <valentina.manea.m@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/