linux-kernel - Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141201085008.GC4994@mwanda>
Date:	Mon, 1 Dec 2014 11:50:09 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Anjana Sasindran <anjanasasindran123@...il.com>
Cc:	gregkh@...uxfoundation.org, joe@...ches.com, m.chehab@...sung.com,
	hans.verkuil@...co.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added
 a '*' before ')'--(parenthesis closing)

On Sun, Nov 30, 2014 at 04:28:02PM +0530, Anjana Sasindran wrote:
> This patch fix a checkpatch.pl error:
> 
> ERROR: space prohibited before ')' parenthesis closing
> 
> Signed-off-by: Anjana Sasindran <anjanasasindran123@...il.com>
> ---
>  drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h b/drivers/staging/media/omap24xx/v4l2-int-device.h
> index 0286c95..9490595 100644
> --- a/drivers/staging/media/omap24xx/v4l2-int-device.h
> +++ b/drivers/staging/media/omap24xx/v4l2-int-device.h
> @@ -292,7 +292,7 @@ V4L2_INT_WRAPPER_1(s_video_routing, struct v4l2_routing, *);
>  
>  V4L2_INT_WRAPPER_0(dev_init);
>  V4L2_INT_WRAPPER_0(dev_exit);
> -V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, );
> +V4L2_INT_WRAPPER_1(s_power, enum v4l2_power, *);

Wait, what?  The changelog for this is not clear.  This looks like
either a bug fix or a bug introducer.

This driver has been deleted in linux-next anyway so I guess it doesn't
matter.  Please work against linux-next.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/