linux-kernel - Re: [PATCH 1/2] arm64: amd-seattle: Fix dma-ranges property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2316008.jChdsJ8v0y@wuerfel>
Date:	Mon, 01 Dec 2014 14:33:42 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	suravee.suthikulpanit@....com, mark.rutland@....com,
	will.deacon@....com, marc.zyngier@....com, catalin.marinas@....com,
	liviu.dudau@....com, linux-kernel@...r.kernel.org, arm@...nel.org,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Subject: Re: [PATCH 1/2] arm64: amd-seattle: Fix dma-ranges property

On Sunday 30 November 2014 21:46:39 suravee.suthikulpanit@....com wrote:
> From: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> 
> AMD Seattle should support 40-bit DMA.
> 
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
> 

The change looks good, but two things about the patch description:

- You should be a little more verbose, especially after we had discussed
  this to some detail on IRC, explain why you use the specific values.

- You should configure git-send-email to know your full email address
  including the name. Right now it gets sent from
  "suravee.suthikulpanit@....com" instead of "Suravee Suthikulpanit
  <Suravee.Suthikulpanit@....com>", and that causes the extra From
  line at the start of the mail, besides looking a bit strange.

Thanks,

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/