lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1417444812-22063-2-git-send-email-kan.liang@intel.com>
Date:	Mon,  1 Dec 2014 09:40:11 -0500
From:	Kan Liang <kan.liang@...el.com>
To:	acme@...nel.org, jolsa@...hat.com, namhyung@...nel.org
Cc:	linux-kernel@...r.kernel.org, ak@...ux.intel.com,
	Kan Liang <kan.liang@...el.com>
Subject: [PATCH V6 2/3] perf tool: new function to compare common part of build-ids

From: Kan Liang <kan.liang@...el.com>

New function to compare the build_ids between different DSOs
This function is only interested in the common part of build_ids.
For example, dsos_a includes DSO A and DSO B. dsos_b includes DSO B and
DSO C. Only DSO B's build_id will be compared.

Signed-off-by: Kan Liang <kan.liang@...el.com>
---

Changes since V5:
 - Replace Arnaldo's dsos__build_ids_equal by bool dsos__build_ids_common_equal
 - Only compare the common part of build-ids

 tools/perf/util/dso.c | 20 ++++++++++++++++++++
 tools/perf/util/dso.h |  2 ++
 2 files changed, 22 insertions(+)

diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
index 45be944..04416b9 100644
--- a/tools/perf/util/dso.c
+++ b/tools/perf/util/dso.c
@@ -1087,3 +1087,23 @@ enum dso_type dso__type(struct dso *dso, struct machine *machine)
 
 	return dso__type_fd(fd);
 }
+
+bool dsos__build_ids_common_equal(struct dsos *dsos_a, struct dsos *dsos_b)
+{
+	struct dso *dso_a, *dso_b;
+
+	list_for_each_entry(dso_a, &dsos_a->head, node) {
+		dso_b = dsos__find(dsos_b, dso_a->short_name, true);
+		if (dso_b == NULL)
+			continue;
+		/*
+		 * Only compare the common part of dsos.
+		 */
+		if (dso_a->has_build_id && dso_b->has_build_id) {
+			if (memcmp(dso_a->build_id, dso_b->build_id, sizeof(dso_a->build_id)))
+				return false;
+		}
+	}
+
+	return true;
+}
diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h
index 3782c82..e92217c 100644
--- a/tools/perf/util/dso.h
+++ b/tools/perf/util/dso.h
@@ -278,4 +278,6 @@ void dso__free_a2l(struct dso *dso);
 
 enum dso_type dso__type(struct dso *dso, struct machine *machine);
 
+bool dsos__build_ids_common_equal(struct dsos *dsos_a, struct dsos *dsos_b);
+
 #endif /* __PERF_DSO */
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ