linux-kernel - RE: [PATCH urgent v2] sched: Add missing rcu protection to wake_up_all_idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27240C0AC20F114CBF8149A2696CBE4A01EE72A9@SHSMSX101.ccr.corp.intel.com>
Date:	Mon, 1 Dec 2014 03:13:26 +0000
From:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
To:	Andy Lutomirski <luto@...capital.net>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Peter Zijlstra <peterz@...radead.org>
Subject: RE: [PATCH urgent v2] sched: Add missing rcu protection to
 wake_up_all_idle_cpus



> -----Original Message-----
> From: Andy Lutomirski [mailto:luto@...capital.net]
> Sent: Sunday, November 30, 2014 12:14 AM
> To: Ingo Molnar; Thomas Gleixner; linux-kernel@...r.kernel.org
> Cc: Peter Zijlstra; Andy Lutomirski; Liu, Chuansheng
> Subject: [PATCH urgent v2] sched: Add missing rcu protection to
> wake_up_all_idle_cpus
> 
> Locklessly doing is_idle_task(rq->curr) is only okay because of RCU
> protection.  The older variant of the broken code checked
> rq->curr == rq->idle instead and therefore didn't need RCU.
> 
> Fixes: f6be8af1c95d sched: Add new API wake_up_if_idle() to wake up the idle
> cpu
> Cc: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> ---
Reviewed-by: Chuansheng Liu <chuansheng.liu@...el.com>

Thanks Andy.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/