| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <547CA303.9000001@users.sourceforge.net> Date: Mon, 01 Dec 2014 18:18:59 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Linux Kernel Mailing List <linux-kernel@...r.kernel.org> CC: kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: [PATCH 1/1] block-skd: Deletion of an unnecessary check before the function call "kfree" From: Markus Elfring <elfring@...rs.sourceforge.net> Date: Mon, 1 Dec 2014 18:15:46 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net> --- drivers/block/skd_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 1e46eb2..c4b0259 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -3998,8 +3998,7 @@ static int skd_acquire_msix(struct skd_device *skdev) return 0; msix_out: - if (entries) - kfree(entries); + kfree(entries); skd_release_msix(skdev); return rc; } -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists