linux-kernel - Re: [PATCH v2] platform: x86: dell-laptop: Add support for keyboard backlight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201412011835.38401@pali>
Date:	Mon, 1 Dec 2014 18:35:38 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Matthew Garrett <mjg59@...f.ucam.org>,
	Darren Hart <dvhart@...radead.org>
Cc:	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	libsmbios-devel@...ts.us.dell.com, Srinivas_G_Gowda@...l.com,
	Michael_E_Brown@...l.com,
	Gabriele Mazzotta <gabriele.mzt@...il.com>
Subject: Re: [PATCH v2] platform: x86: dell-laptop: Add support for keyboard backlight

On Sunday 23 November 2014 15:50:45 Pali Rohár wrote:
> This patch adds support for configuring keyboard backlight
> settings on supported Dell laptops. It exports kernel leds
> interface and uses Dell SMBIOS tokens or keyboard class
> interface.
> 
> With this patch it is possible to set:
> * keyboard backlight level
> * timeout after which will be backlight automatically turned
> off * input activity triggers (keyboard, touchpad, mouse)
> which enable backlight * ambient light settings
> 
> Settings are exported via sysfs:
> /sys/class/leds/dell::kbd_backlight/
> 
> Code is based on newly released documentation by Dell in
> libsmbios project.
> 
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
> ---
> Changes since v1:
> * returns also -EIO/-ENXIO (with helper function
> dell_smi_error) * simplify code to have less levels of
> indentation
> * style fixes
> * add some comments
> ---
>  drivers/platform/x86/dell-laptop.c | 1023
> +++++++++++++++++++++++++++++++++++- 1 file changed, 1019
> insertions(+), 4 deletions(-)
> 

Darren, Matthew: can you review this v2 code?

I would like to see keyboard backlight support in 3.19 kernel.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)