lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Dec 2014 10:43:24 -0800 From: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> To: lizf@...nel.org Cc: stable@...r.kernel.org, linux-kernel@...r.kernel.org, Cong Wang <cwang@...pensource.com>, Cong Wang <xiyou.wangcong@...il.com>, Peter Zijlstra <peterz@...radead.org>, Paul Mackerras <paulus@...ba.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Ingo Molnar <mingo@...nel.org>, Zefan Li <lizefan@...wei.com> Subject: Re: [PATCH 3.4 43/91] perf: Fix a race condition in perf_remove_from_context() lizf@...nel.org [lizf@...nel.org] wrote: | From: Cong Wang <cwang@...pensource.com> | | 3.4.105-rc1 review patch. If anyone has any objections, please let me know. | <snip> | | diff --git a/kernel/events/core.c b/kernel/events/core.c | index 685ce46..c958be1 100644 | --- a/kernel/events/core.c | +++ b/kernel/events/core.c | @@ -1702,6 +1702,16 @@ retry: | */ | if (ctx->is_active) { | raw_spin_unlock_irq(&ctx->lock); | + /* | + * Reload the task pointer, it might have been changed by | + * a concurrent perf_event_context_sched_out(). | + */ | + task = ctx->task; | + /* | + * Reload the task pointer, it might have been changed by | + * a concurrent perf_event_context_sched_out(). | + */ | + task = ctx->task; Something wrong in the way the patch was applied ? The lines are identical... The original commit, 3577af70, has the change applied in two places: perf_event_disable() and perf_remove_from_context(). | goto retry; | } | | -- | 1.9.1 | | -- | To unsubscribe from this list: send the line "unsubscribe linux-kernel" in | the body of a message to majordomo@...r.kernel.org | More majordomo info at http://vger.kernel.org/majordomo-info.html | Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists