linux-kernel - Re: [PATCH] hid: export hid_report_len as an inline function in hid.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4TJGJ0rx1L3iXiNRPbcy3NZ=ZOiGXzHRjKUfgsiTk+S1g@mail.gmail.com>
Date:	Mon, 1 Dec 2014 20:04:01 +0100
From:	David Herrmann <dh.herrmann@...il.com>
To:	Benjamin Tissoires <benjamin.tissoires@...il.com>
Cc:	Mathieu Magnaudet <mathieu.magnaudet@...il.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-input <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hid: export hid_report_len as an inline function in hid.h

Hi

On Mon, Dec 1, 2014 at 7:22 PM, Benjamin Tissoires
<benjamin.tissoires@...il.com> wrote:
> On Thu, Nov 27, 2014 at 10:02 AM, Mathieu Magnaudet
> <mathieu.magnaudet@...il.com> wrote:
>> in several hid drivers it is necessary to calculate the length
>> of an hid_report. This patch exports the existing static function
>> hid_report_len of hid-core.c as an inline function in hid.h
>>
>> Signed-off-by: Mathieu Magnaudet <mathieu.magnaudet@...c.fr>
>> ---
>
> IIRC, there are a few more custom report length computations
> throughout the HID tree. They are not straightforward to convert, so I
> think we have a pretty good start here.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...il.com>

I fully agree!

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/