linux-kernel - Re: [PATCHv3 1/1] HID: add BETOP game controller force feedback support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1412012111020.2524@pobox.suse.cz>
Date:	Mon, 1 Dec 2014 21:11:51 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Huang Bo <huangbobupt@....com>
cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 1/1] HID: add BETOP game controller force feedback
 support

On Fri, 28 Nov 2014, Huang Bo wrote:

> On 11/27/2014 05:05 PM, Jiri Kosina wrote:
> > except ...
> thanks firstly.
> 1. tested the BETOP2185 gamecontroller, it really not need it.
> 2. check with engineers of Betop, they design only one report descriptor.
> 
> so I modify it.

Thanks, but please put the comment into the code (jus before you are 
zeroing the fields), so that it's immediately obvious to everybody who is 
reading the code.

Other than that, I am OK with the patch and will be applying it once you 
resend it with the comments added.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/