linux-kernel - Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before irq_dispose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141201201637.GQ7712@sirena.org.uk>
Date:	Mon, 1 Dec 2014 20:16:37 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Timur Tabi <timur@...i.org>, linuxppc-dev@...ts.ozlabs.org,
	Lars-Peter Clausen <lars@...afoo.de>,
	alsa-devel@...a-project.org, Jiada Wang <jiada_wang@...tor.com>,
	linux-kernel@...r.kernel.org, lgirdwood@...il.com,
	nicoleotsuka@...il.com, tiwai@...e.de, Li.Xiubo@...escale.com,
	Markus Pargmann <mpa@...gutronix.de>
Subject: Re: [alsa-devel] [PATCH] ASoC: fsl_ssi: free irq before
 irq_dispose_mapping()

On Mon, Dec 01, 2014 at 09:01:43PM +0100, Arnd Bergmann wrote:
> On Monday 01 December 2014 13:59:27 Timur Tabi wrote:
> > On 12/01/2014 01:56 PM, Arnd Bergmann wrote:

> > > All other drivers that call irq_of_parse_and_map and pass that into
> > > devm_request_irq just never unmap, and their interrupts are already
> > > mapped by the platform code, so I think it's not even a leak.

> > Does this mean that fsl_ssi.c should not be calling 
> > irq_of_parse_and_map?  How else should it get the IRQ?

> platform_get_irq()

Right, and just to emphasize what we were saying earlier the code was
fine when originally written - both mapping inside platform_get_irq()
and devm_ came along quite a while after the driver was originally
written.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)