linux-kernel - Re: [PATCH] scripts/package: binrpm-pkg do not build source tar file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141201211103.GA32057@gmail.com>
Date:	Mon, 1 Dec 2014 16:11:06 -0500
From:	Jerome Glisse <j.glisse@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kernel@...r.kernel.org,
	Jérôme Glisse <jglisse@...hat.com>,
	linux-kbuild@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] scripts/package: binrpm-pkg do not build source tar file

On Thu, Nov 27, 2014 at 03:33:41PM +0100, Michal Marek wrote:
> On 2014-10-31 20:05, j.glisse@...il.com wrote:
> > From: Jérôme Glisse <jglisse@...hat.com>
> > 
> > When doing make binrpm-pkg we do not want to build the source tar
> > file. This patch avoid doing the gigantic tar file.
> > 
> > Signed-off-by: Jérôme Glisse <jglisse@...hat.com>
> > Cc: linux-kbuild@...r.kernel.org
> > Cc: Michal Marek <mmarek@...e.cz>
> > Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> > ---
> >  scripts/package/mkspec | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/scripts/package/mkspec b/scripts/package/mkspec
> > index 1395760..b6f5e31 100755
> > --- a/scripts/package/mkspec
> > +++ b/scripts/package/mkspec
> > @@ -119,8 +119,10 @@ echo "%endif"
> >  
> >  echo 'rm -f $RPM_BUILD_ROOT'"/lib/modules/$KERNELRELEASE/{build,source}"
> >  echo "mkdir -p "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE"
> > +if ! $PREBUILT; then
> >  echo "EXCLUDES=\"$RCS_TAR_IGNORE --exclude .tmp_versions --exclude=*vmlinux* --exclude=*.o --exclude=*.ko --exclude=*.cmd --exclude=Documentation --exclude=firmware --exclude .config.old --exclude .missing-syscalls.d\""
> >  echo "tar "'$EXCLUDES'" -cf- . | (cd "'$RPM_BUILD_ROOT'"/usr/src/kernels/$KERNELRELEASE;tar xvf -)"
> > +fi
> 
> This does not generate any tar file, but a /usr/src/kernels/... tree to
> be packaged in the kernel-devel package. I'm not says we should be doing
> this in make binrpm-pkg, but the change should also remove the
> kernel-devel package in the binrpm-pkg case.

Sent a v2 that also avoid building the devel package for binrpm-pkg target.

Cheers,
Jérôme

> 
> Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/