linux-kernel - Re: [PATCH] staging:lustre:lnet: Incorrect type in assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1417415594.4894.1.camel@perches.com>
Date:	Sun, 30 Nov 2014 22:33:14 -0800
From:	Joe Perches <joe@...ches.com>
To:	sunwxg <sun.wxg@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Amir Shehata <amir.shehata@...el.com>,
	Peng Tao <bergwolf@...il.com>,
	Doug Oucharek <doug.s.oucharek@...el.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:lustre:lnet: Incorrect type in assignment

On Mon, 2014-12-01 at 14:18 +0800, sunwxg wrote:
> Incorrect type when assign value to varible iov_base.
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/staging/lustre/lnet/lnet/lib-move.c
[]
> @@ -256,7 +256,8 @@ lnet_extract_iov(int dst_niov, struct iovec *dst,
>  		LASSERT((int)niov <= dst_niov);
>  
>  		frag_len = src->iov_len - offset;
> -		dst->iov_base = ((char *)src->iov_base) + offset;
> +		dst->iov_base = (void __user *)
> +				(((char *)src->iov_base) + offset);

Just use void * arithmetic and remove the cast

		dst->iov_base = src->iov_base + offset;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/