linux-kernel - Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141125215804.GC116670@vmdeb7>
Date:	Tue, 25 Nov 2014 13:58:06 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	Alex Hung <alex.hung@...onical.com>
Subject: Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch
 driver

On Fri, Nov 28, 2014 at 01:54:57PM +0200, Mika Westerberg wrote:
> On Fri, Nov 28, 2014 at 12:45:55PM +0100, Pali Rohár wrote:
> > Hello,
> > 
> > I will fix all those style problems and add some comments.
> > 
> > On Friday 28 November 2014 12:33:28 Mika Westerberg wrote:
> > > > +	if (ACPI_FAILURE(status))
> > > > +		return;
> > > > +
> > > > +	rfkill_set_states(rfkill, !output, !output);
> > > 
> > > You can also write it like:
> > > 
> > > 	if (ACPI_SUCCESS(status))
> > > 		rfkill_set_states(rfkill, !output, !output);
> > > 
> > > which looks better to me at least.
> > > 
> > 
> > In whole module I'm using this style:
> > 
> > f1();
> > if (f1_failed)
> > 	return;
> > f2()
> > if (f2_failed)
> > 	return;
> > 
> > So I would like not to change it for one function.
> 
> Fair enough.

And, in my opinion, it is better to test for errors than to test for success.
This keeps the main logic out of a nested block. Not so critical here, but a
good rule of thumb.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/