linux-kernel - Re: [PATCH 0/3] Dell Airplane Mode Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201412020942.47091@pali>
Date:	Tue, 2 Dec 2014 09:42:47 +0100
From:	Pali Rohár <pali.rohar@...il.com>
To:	Darren Hart <dvhart@...radead.org>
Cc:	Matthew Garrett <mjg59@...f.ucam.org>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gabriele Mazzotta <gabriele.mzt@...il.com>,
	Alex Hung <alex.hung@...onical.com>
Subject: Re: [PATCH 0/3] Dell Airplane Mode Switch driver

On Wednesday 26 November 2014 00:05:28 Darren Hart wrote:
> On Sun, Nov 23, 2014 at 04:09:18PM +0100, Pali Rohár wrote:
> > This patch series add new acpi Dell Airplane Mode Switch
> > driver (DELLABCE and DELRBTN acpi devices). It provides
> > radio HW switch events (together with current state of
> > radio devices) and export them via rfkill interface. These
> > events are also used in dell-laptop driver instead i8042
> > filter hook function (when acpi device is available).
> > 
> > Pali Rohár (3):
> >   platform: x86: dell-rbtn: Dell Airplane Mode Switch driver
> >   platform: x86: dell-rbtn: Export notifier for other kernel
> >   modules platform: x86: dell-laptop: Use dell-rbtn instead
> >   i8042 filter when
> >   
> >     possible
> >  
> >  drivers/platform/x86/Kconfig       |   14 ++
> >  drivers/platform/x86/Makefile      |    1 +
> >  drivers/platform/x86/dell-laptop.c |   67 +++++++++-
> >  drivers/platform/x86/dell-rbtn.c   |  260
> >  ++++++++++++++++++++++++++++++++++++
> >  drivers/platform/x86/dell-rbtn.h   |   35 +++++
> >  5 files changed, 372 insertions(+), 5 deletions(-)
> >  create mode 100644 drivers/platform/x86/dell-rbtn.c
> >  create mode 100644 drivers/platform/x86/dell-rbtn.h
> 
> Alex, it is my understanding that this solution from Pali is a
> more complete solution to dealing with the variety of dell
> wireless buttons and rfkill mechanisms in the world today.
> 
> I currently have:
> 7c4d961 dell-wireless: new driver for dell wireless button for
> Windows 8 queued in for-next. If I have read your responses
> on this correctly, are we all in agreement that I should drop
> the above patch, and apply these?

Darren, it it truth that some laptops does not send keypress 
event when Fn+wifi key is pressed (but only send ACPI event), 
then really Alex's patch for input device is needed. But it could 
be integrated into my driver. Also Alex wrote something about 
ACPI events for laptops which have wifi key instead HW switch. So 
before including this patch into tree, I would like to hear what 
is problem with my patch for laptops which have wifi key...

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)