linux-kernel - Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Dec 2014 09:42:51 +0000
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Michal Simek <michal.simek@...inx.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, monstr <monstr@...str.eu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Laura Abbott <lauraa@...eaurora.org>,
	Olof Johansson <olof@...om.net>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Subject: Re: [PATCH v1] lib/genalloc.c: Export devm_gen_pool_create for modules

Hi Michal,

On Tue, Dec 2, 2014 at 9:36 AM, Michal Simek <michal.simek@...inx.com> wrote:
> On 12/02/2014 10:31 AM, Prabhakar Lad wrote:
>> Hi Michal,
>>
>> Thanks for the patch.
>>
>> On Mon, Dec 1, 2014 at 1:00 PM, Michal Simek <michal.simek@...inx.com> wrote:
>>> Modules can use this function for creating pool.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>>> ---
>>>
>>> I am pushing Zynq OCMC driver which is using this function.
>>>
>>> ---
>>>  lib/genalloc.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>> don’t you need to add an entry in include/linux/genalloc.h ?
>
> Not sure what exactly you mean. declaration is there.
> include/linux/genalloc.h:120:extern struct gen_pool *devm_gen_pool_create(struct device *dev,
>
> And all EXPORT_SYMBOL() are out of headers directly below function
> which you want to export.
>
> Can you please clarify what you did mean by that?
>
Oops missed it, since it was a exported function I was expecting a entry
in a header file, but yes the entry  exists already so,

Acked-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/