linux-kernel - Re: [PATCH v8 03/50] mic_virtio: robust feature array size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141202111346.785c6f31@oc7435384737.ibm.com>
Date:	Tue, 2 Dec 2014 11:13:46 +0100
From:	Thomas Huth <thuth@...ux.vnet.ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	cornelia.huck@...ibm.com, rusty@....ibm.com, nab@...ux-iscsi.org,
	pbonzini@...hat.com, dahi@...ux.vnet.ibm.com,
	Rusty Russell <rusty@...tcorp.com.au>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Siva Yerramreddy <yshivakrishna@...il.com>
Subject: Re: [PATCH v8 03/50] mic_virtio: robust feature array size
 calculation

On Mon, 1 Dec 2014 18:02:59 +0200
"Michael S. Tsirkin" <mst@...hat.com> wrote:

> mic reads sizeof(vdev->features) bits from device, but in fact it stores
> bits in local features variable. use sizeof(features) to make code
> robust against future changes extending sizeof(vdev->features).
> 
> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/misc/mic/card/mic_virtio.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mic/card/mic_virtio.c b/drivers/misc/mic/card/mic_virtio.c
> index 4f070ad..d5da9ff 100644
> --- a/drivers/misc/mic/card/mic_virtio.c
> +++ b/drivers/misc/mic/card/mic_virtio.c
> @@ -76,8 +76,7 @@ static u32 mic_get_features(struct virtio_device *vdev)
>  	u8 __iomem *in_features = mic_vq_features(desc);
>  	int feature_len = ioread8(&desc->feature_len);
> 
> -	bits = min_t(unsigned, feature_len,
> -		sizeof(vdev->features)) * 8;
> +	bits = min_t(unsigned, feature_len, sizeof(features)) * 8;
>  	for (i = 0; i < bits; i++)
>  		if (ioread8(&in_features[i / 8]) & (BIT(i % 8)))
>  			features |= BIT(i);

Reviewed-by: Thomas Huth <thuth@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/