linux-kernel - Re: [PATCH] staging: unisys: remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141202103907.GA9991@sudip-PC>
Date:	Tue, 2 Dec 2014 16:09:07 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	sparmaintainer@...sys.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: unisys: remove duplicate header

On Tue, Dec 02, 2014 at 01:46:54AM -0800, Jeremiah Mahler wrote:
> Sudip,
> 
> On Tue, Dec 02, 2014 at 02:34:58PM +0530, Sudip Mukherjee wrote:
> > these header files were included two times
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> >  drivers/staging/unisys/include/timskmod.h | 1 -
> >  drivers/staging/unisys/uislib/uisutils.c  | 1 -
> >  2 files changed, 2 deletions(-)
> > 
> > diff --git a/drivers/staging/unisys/include/timskmod.h b/drivers/staging/unisys/include/timskmod.h
> > index de11f44..cff7983 100644
> > --- a/drivers/staging/unisys/include/timskmod.h
> > +++ b/drivers/staging/unisys/include/timskmod.h
> > @@ -31,7 +31,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/errno.h>
> >  #include <linux/interrupt.h>
> > -#include <linux/sched.h>
> >  #include <linux/wait.h>
> >  #include <linux/vmalloc.h>
> >  #include <linux/proc_fs.h>
> > diff --git a/drivers/staging/unisys/uislib/uisutils.c b/drivers/staging/unisys/uislib/uisutils.c
> > index a8466e3..7149add 100644
> > --- a/drivers/staging/unisys/uislib/uisutils.c
> > +++ b/drivers/staging/unisys/uislib/uisutils.c
> > @@ -27,7 +27,6 @@
> >  #include "vbushelper.h"
> >  #include <linux/uuid.h>
> >  #include <linux/skbuff.h>
> > -#include <linux/uuid.h>
> >  #ifdef CONFIG_HIGHMEM
> >  #include <linux/highmem.h>
> >  #endif
> 
> There are two duplicates of the second one.  Lines: 21, 28 and 30.

oops ... missed that
i will send a v2

thanks
sudip
> 
> Good find :
> 
> -- 
> - Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/