linux-kernel - Re: [PATCH v8 1/4] irqchip: gic: Support hierarchy irq domain.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVkH_qshTfpXBcHx1FiEzL8055s1TiJqayWLXeFUf97NQ@mail.gmail.com>
Date:	Tue, 2 Dec 2014 14:55:13 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Marc Zyngier <marc.zyngier@....com>
Cc:	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Mark Rutland <Mark.Rutland@....com>,
	Jason Cooper <jason@...edaemon.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <Pawel.Moll@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"hc.yen@...iatek.com" <hc.yen@...iatek.com>,
	"srv_heupstream@...iatek.com" <srv_heupstream@...iatek.com>,
	"yh.chen@...iatek.com" <yh.chen@...iatek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	Yijing Wang <wangyijing@...wei.com>,
	Rob Herring <robh+dt@...nel.org>,
	"nathan.chung@...iatek.com" <nathan.chung@...iatek.com>,
	"yingjoe.chen@...il.com" <yingjoe.chen@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	"eddie.huang@...iatek.com" <eddie.huang@...iatek.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH v8 1/4] irqchip: gic: Support hierarchy irq domain.

Hi Marc,

On Tue, Dec 2, 2014 at 2:37 PM, Marc Zyngier <marc.zyngier@....com> wrote:
> On 02/12/14 13:27, Geert Uytterhoeven wrote:
>> On Tue, Nov 25, 2014 at 9:04 AM, Yingjoe Chen <yingjoe.chen@...iatek.com> wrote:
>>> Add support to use gic as a parent for stacked irq domain.
>>>
>>> Signed-off-by: Yingjoe Chen <yingjoe.chen@...iatek.com>
>>
>> This change (which is now in -next as commit 9a1091ef0017c40a) breaks
>> booting on r8a7740/armadillo-legacy.
>>
>> It hangs because the timers cannot get their interrupts:
>>
>> console [tty0] enabled
>>  sh-tmu.0: ch0: used for clock events
>>  sh-tmu.0: ch0: used for periodic clock events
>>  sh-tmu.0: ch0: failed to request irq 230
>>  sh-tmu.0: ch1: used as clock source
>>  sh-cmt-48.1: ch0: failed to request irq 90
>>  sh-cmt-48.1: ch0: registration failed
>> earlytimer: unable to probe sh-cmt-48 early.
>> Calibrating delay loop...
>
> Grmbl... Are you, by any (lack of) chance, using a setup where the GIC
> is probed via DT, but the timers have their IRQs hardcoded?

Yes, the GIC is declared in arch/arm/boot/dts/r8a7740.dtsi:

        gic: interrupt-controller@...00000 {
                compatible = "arm,cortex-a9-gic";
                #interrupt-cells = <3>;
                interrupt-controller;
                reg = <0xc2800000 0x1000>,
                      <0xc2000000 0x1000>;
        };

The timers come from legacy C board code in
arch/arm/mach-shmobile/setup-r8a7740.c:

/* CMT */
static struct sh_timer_config cmt1_platform_data = {
        .channels_mask = 0x3f,
};

static struct resource cmt1_resources[] = {
        DEFINE_RES_MEM(0xe6138000, 0x170),
        DEFINE_RES_IRQ(gic_spi(58)),
};

static struct platform_device cmt1_device = {
        .name           = "sh-cmt-48",
        .id             = 1,
        .dev = {
                .platform_data  = &cmt1_platform_data,
        },
        .resource       = cmt1_resources,
        .num_resources  = ARRAY_SIZE(cmt1_resources),
};

/* TMU */
static struct sh_timer_config tmu0_platform_data = {
        .channels_mask = 7,
};

static struct resource tmu0_resources[] = {
        DEFINE_RES_MEM(0xfff80000, 0x2c),
        DEFINE_RES_IRQ(gic_spi(198)),
        DEFINE_RES_IRQ(gic_spi(199)),
        DEFINE_RES_IRQ(gic_spi(200)),
};

static struct platform_device tmu0_device = {
        .name           = "sh-tmu",
        .id             = 0,
        .dev = {
                .platform_data  = &tmu0_platform_data,
        },
        .resource       = tmu0_resources,
        .num_resources  = ARRAY_SIZE(tmu0_resources),
};

The corresponding r8a7740/armadillo-multiplatform works fine.

Still, I'm wondering why sh73a0/kzm9g-legacy is not impacted by this
change...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/