linux-kernel - Re: [PATCH] dmaengine: fsl-edma: fix calculation of remaining bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f5e46d80c45693b12c3ad8691d3c90a@agner.ch>
Date:	Tue, 02 Dec 2014 17:53:01 +0100
From:	Stefan Agner <stefan@...er.ch>
To:	vinod.koul@...el.com
Cc:	jingchang.lu@...escale.com, dan.j.williams@...el.com,
	dmaengine@...r.kernel.org, shawn.guo@...aro.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] dmaengine: fsl-edma: fix calculation of remaining bytes

On 2014-11-13 12:56, Stefan Agner wrote:
> If the current transfer control descriptor (TCD) was not yet started,
> the address will be the same as the initial address. Hence test if the
> current address is less than or equal to the start address of each TCD.
> 
> Signed-off-by: Stefan Agner <stefan@...er.ch>
> ---
> This bug was discovered during development on a AC97 capable SAI driver,
> I don't think that this is currently a issue since only a few drivers
> use DMA on Vybrid so far and don't use the remaining bytes information.
> 
>  drivers/dma/fsl-edma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsl-edma.c b/drivers/dma/fsl-edma.c
> index 3c5711d..58c6fc7 100644
> --- a/drivers/dma/fsl-edma.c
> +++ b/drivers/dma/fsl-edma.c
> @@ -386,7 +386,7 @@ static size_t fsl_edma_desc_residue(struct
> fsl_edma_chan *fsl_chan,
>  					&(edesc->tcd[i].vtcd->daddr));
>  
>  		len -= size;
> -		if (cur_addr > dma_addr && cur_addr < dma_addr + size) {
> +		if (cur_addr >= dma_addr && cur_addr < dma_addr + size) {
>  			len += dma_addr + size - cur_addr;
>  			break;
>  		}

Hi Vinod,

Afaik, this has not been applied yet, any reasons why?

--
Stefan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/