linux-kernel - Re: [PATCH] sb_edac: Fix typo computing number of banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141202181757.GE21208@redhat.com>
Date:	Tue, 2 Dec 2014 13:17:58 -0500
From:	Aristeu Rozanski <aris@...hat.com>
To:	Tony Luck <tony.luck@...el.com>
Cc:	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	Borislav Petkov <bp@...en8.de>, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sb_edac: Fix typo computing number of banks

On Tue, Dec 02, 2014 at 09:41:58AM -0800, Tony Luck wrote:
> Code will always think there are 16 banks because of a typo
> 
> Reported-by: Misha
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---
> 
> Not sure if Misha is shy, or just busy. But my attempt to get
> them to post their own patch didn't work
> 
>  drivers/edac/sb_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 993e8b61c4b2..63aa6730e89e 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -901,7 +901,7 @@ static int get_dimm_config(struct mem_ctl_info *mci)
>  	else
>  		edac_dbg(0, "Memory is unregistered\n");
>  
> -	if (mtype == MEM_DDR4 || MEM_RDDR4)
> +	if (mtype == MEM_DDR4 || mtype == MEM_RDDR4)
>  		banks = 16;
>  	else
>  		banks = 8;

ACK

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/