linux-kernel - Re: [PATCH 1/1] ALSA: trident: Deletion of a check before snd_util_memhdr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h1toh98a1.wl-tiwai@suse.de>
Date:	Tue, 02 Dec 2014 20:11:18 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 1/1] ALSA: trident: Deletion of a check before snd_util_memhdr_free()

At Tue, 02 Dec 2014 18:56:30 +0100,
SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 2 Dec 2014 18:52:21 +0100
> 
> The snd_util_memhdr_free() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Applied, thanks.


Takashi

> ---
>  sound/pci/trident/trident_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/pci/trident/trident_main.c b/sound/pci/trident/trident_main.c
> index da875dc..57cd757 100644
> --- a/sound/pci/trident/trident_main.c
> +++ b/sound/pci/trident/trident_main.c
> @@ -3702,8 +3702,7 @@ static int snd_trident_free(struct snd_trident *trident)
>  		free_irq(trident->irq, trident);
>  	if (trident->tlb.buffer.area) {
>  		outl(0, TRID_REG(trident, NX_TLBC));
> -		if (trident->tlb.memhdr)
> -			snd_util_memhdr_free(trident->tlb.memhdr);
> +		snd_util_memhdr_free(trident->tlb.memhdr);
>  		if (trident->tlb.silent_page.area)
>  			snd_dma_free_pages(&trident->tlb.silent_page);
>  		vfree(trident->tlb.shadow_entries);
> -- 
> 2.1.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/