linux-kernel - Re: [PATCH] sound: pci: cmipci.c: Cleaning up function that are not used anywhere

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo5kFRHjUtNghkL_Db2BaKFOG5vM-rnUOTZAsvFPDd8ebw@mail.gmail.com>
Date:	Tue, 2 Dec 2014 16:51:30 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Benoit Taine <benoit.taine@...6.fr>,
	alsa-devel <alsa-devel@...a-project.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sound: pci: cmipci.c: Cleaning up function that are not
 used anywhere

Hi Rickard,

Thanks a lot for fixing cruft like this.  It makes life better for everybody.

I'll let the maintainer of this driver take care of this patch, but
I'll just point out that your subject ("Cleaning up function ...") is
slightly ambiguous because sometimes "cleanup" means simplification,
not removal.  My personal preference would be "Remove unused
snd_cmipci_pll_rmn()" because it is unambiguous, shorter, and contains
a little more information.  That makes "git log --oneline" output more
 useful.

Bjorn

On Tue, Dec 2, 2014 at 4:12 PM, Rickard Strandqvist
<rickard_strandqvist@...ctrumdigital.se> wrote:
> Remove function snd_cmipci_pll_rmn() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  sound/pci/cmipci.c |   41 -----------------------------------------
>  1 file changed, 41 deletions(-)
>
> diff --git a/sound/pci/cmipci.c b/sound/pci/cmipci.c
> index 85ed403..e33edae 100644
> --- a/sound/pci/cmipci.c
> +++ b/sound/pci/cmipci.c
> @@ -615,47 +615,6 @@ static unsigned int snd_cmipci_rate_freq(unsigned int rate)
>
>  #ifdef USE_VAR48KRATE
>  /*
> - * Determine PLL values for frequency setup, maybe the CMI8338 (CMI8738???)
> - * does it this way .. maybe not.  Never get any information from C-Media about
> - * that <werner@...e.de>.
> - */
> -static int snd_cmipci_pll_rmn(unsigned int rate, unsigned int adcmult, int *r, int *m, int *n)
> -{
> -       unsigned int delta, tolerance;
> -       int xm, xn, xr;
> -
> -       for (*r = 0; rate < CM_MAXIMUM_RATE/adcmult; *r += (1<<5))
> -               rate <<= 1;
> -       *n = -1;
> -       if (*r > 0xff)
> -               goto out;
> -       tolerance = rate*CM_TOLERANCE_RATE;
> -
> -       for (xn = (1+2); xn < (0x1f+2); xn++) {
> -               for (xm = (1+2); xm < (0xff+2); xm++) {
> -                       xr = ((CM_REFFREQ_XIN/adcmult) * xm) / xn;
> -
> -                       if (xr < rate)
> -                               delta = rate - xr;
> -                       else
> -                               delta = xr - rate;
> -
> -                       /*
> -                        * If we found one, remember this,
> -                        * and try to find a closer one
> -                        */
> -                       if (delta < tolerance) {
> -                               tolerance = delta;
> -                               *m = xm - 2;
> -                               *n = xn - 2;
> -                       }
> -               }
> -       }
> -out:
> -       return (*n > -1);
> -}
> -
> -/*
>   * Program pll register bits, I assume that the 8 registers 0xf8 up to 0xff
>   * are mapped onto the 8 ADC/DAC sampling frequency which can be chosen
>   * at the register CM_REG_FUNCTRL1 (0x04).
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/