linux-kernel - Re: [patch] CodingStyle: add some more error handling guidelines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <547F98A3.7090509@users.sourceforge.net>
Date:	Thu, 04 Dec 2014 00:11:31 +0100
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Arend van Spriel <arend@...adcom.com>
CC:	Dan Carpenter <dan.carpenter@...cle.com>,
	Julia Lawall <julia.lawall@...6.fr>, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Jonathan Corbet <corbet@....net>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Coccinelle <cocci@...teme.lip6.fr>, backports@...r.kernel.org,
	Johannes Berg <johannes@...solutions.net>,
	"Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [patch] CodingStyle: add some more error handling guidelines

> Please provide your point of view.

I would like to interpret the key word "goto" from the C programming
language a bit more here so that a better common understanding can
eventually be achieved.

Strong opinions might be floating around for the consistent naming
of jump labels. My reasoning works like the following.

This key word could also be interpreted as two items "go" and "to",
couldn't it?
How much does this variation stress its meaning in a specific direction?

Some software developers would like to express the reason about
an unexpected event at the jump source. But I guess that this approach
increases the risk for a popular story like "goto fail;", doesn't it?
I would prefer not to specify "go to failure".

So I find that there are more variants possible to stress the jump target.
Examples:
* Failure_exit
* out_memory_release
* unregister_item

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/